Skip to content

Conversation

@dbaron
Copy link
Member

@dbaron dbaron commented Jun 30, 2023

[css-backgrounds-4][css-box-3][css-color-hdr][css-module][css-writing-modes-3][css-writing-modes-4] Convert remaining "Animatable" lines to "Animation type" lines.

See #72.

…-modes-3][css-writing-modes-4] Convert remaining Animatable lines to Animation type lines.
@dbaron dbaron requested a review from fantasai June 30, 2023 21:38
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, but what does Animatable: n/a mean? Is it the same as not animatable?

@yarusome
Copy link
Contributor

yarusome commented Jul 1, 2023

This resolution implies that writing-mode should be "not animatable", but the final resolution says differently from the proposed one.

@dbaron
Copy link
Member Author

dbaron commented Jul 1, 2023

This all looks good, but what does Animatable: n/a mean? Is it the same as not animatable?

The "n/a" values are for a propdef table that's for an alias rather than a real property. (Perhaps aliases should be more like shorthands and say "see aliased property" or something like that.)

This resolution implies that writing-mode should be "not animatable", but the final resolution says differently from the proposed one.

Based on that resolution I agree that like writing-mode, direction, and unicode-bidi should all be not animatable rather than discrete. But I don't see anything in this PR that's changing those properties.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svgeesus svgeesus merged commit 4b7bc9e into w3c:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants