Skip to content

[css-view-transitions-1] Refactor VT old capture algorithm #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2023
Merged

[css-view-transitions-1] Refactor VT old capture algorithm #9135

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ecfcf3
Refactor VT old capture algorithm
vmpstr Aug 1, 2023
d686282
update
vmpstr Aug 1, 2023
5a25592
update
vmpstr Aug 1, 2023
4920487
update
vmpstr Aug 1, 2023
ccaddaf
Typo
khushalsagar Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions css-view-transitions-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,6 +1314,8 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. Let |usedTransitionNames| be a new [=/set=] of strings.

1. Let |captureElements| be a new [=/list=] of elements.

1. Let |document| be |transition|'s [=relevant global object's=] [=associated document=].

1. Set |transition|'s [=ViewTransition/initial snapshot containing block size=] to the [=snapshot containing block size=].
Expand All @@ -1322,6 +1324,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
and has a [=node document=] equal to to |document|,
in [paint order](https://drafts.csswg.org/css2/#painting-order):

<div class=note>We iterate in paint order to ensure that this order is cached in |namedElements|.
This defines the DOM order for ::view-transition-group pseudo-elements, such that the element at the bottom of the paint stack generates the first pseudo child of ::view-transition.</div>

1. If any [=flat tree=] ancestor of this |element| [=skips its contents=], then [=continue=].

1. If |element| has more than one [=box fragment=], then [=continue=].
Expand All @@ -1339,6 +1344,14 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. [=set/Append=] |transitionName| to |usedTransitionNames|.

1. Set |element|'s [=captured in a view transition=] to true.

1. [=list/Append=] |element| to |captureElements|.

<div class="note">The algorithm continues in a separate loop to ensure that [=captured in a view transition=] is set on all elements participating in this capture before it is read by future steps in the algorithm.</div>

1. [=list/For each=] |element| in |captureElements|:

1. Let |capture| be a new [=captured element=] struct.

1. Set |capture|'s [=old image=] to the result of [=capturing the image=] of |element|.
Expand All @@ -1363,7 +1376,13 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. Set |capture|'s [=captured element/old mix-blend-mode=] to the [=computed value=] of 'mix-blend-mode' on |element|.

1. Let |transitionName| be the [=computed value=] of 'view-transition-name' for |element|.

1. Set |namedElements|[|transitionName|] to |capture|.

1. [=list/For each=] |element| in |captureElements|:

1. Set |element|'s [=captured in a view transition=] to false.
</div>

### [=Capture the new state=] ### {#capture-new-state-algorithm}
Expand Down Expand Up @@ -1855,6 +1874,7 @@ Changes from <a href="https://www.w3.org/TR/2023/WD-css-view-transitions-1-20230
* Use a keyframe to add plus-lighter blending during cross-fade. See <a href="https://github.com/w3c/csswg-drafts/issues/8924">issue 8924</a>.
* Add mix-blend-mode to list of properties copied over to the ''::view-transition-group''. See <a href="https://github.com/w3c/csswg-drafts/issues/8962">issue 8962</a>.
* Add text-orientation to list of properties copied over to the ''::view-transition-group''. See <a href="https://github.com/w3c/csswg-drafts/issues/8230">issue 8230</a>.
* Refactor the old capture algorithm to properly set [=captured in a view transition=] before reading the value.

<h3 id="changes-since-2022-05-25">
Changes from <a href="https://www.w3.org/TR/2023/WD-css-view-transitions-1-20230525/">2022-05-25 Working Draft</a>
Expand Down