Skip to content

[css-text-4] Clarify fonts without enough blank may not be trimmed #9225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kojiishi merged 4 commits into from
Oct 30, 2023
Merged

[css-text-4] Clarify fonts without enough blank may not be trimmed #9225

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7c08a8
text-spacing-trim-give-up
kojiishi Aug 23, 2023
358879d
frivoal review
kojiishi Oct 23, 2023
75b3afc
Fix typo.
kojiishi Oct 23, 2023
ef7bb37
Merge branch 'main' into text-spacing-trim-give-up
kojiishi Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions css-text-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8337,6 +8337,13 @@ Fullwidth Punctuation Collapsing</h4>
the font has proportional ideographs
and the fullwidth advance width cannot be reliably determined by measuring glyphs.

Some fonts have fullwidth punctuation characters
whose blank are too small to trim (kern.)
UA may not trim (kern)
Copy link
Collaborator

@frivoal frivoal Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UA may not trim (kern)
UA may choose not to trim (kern)

Otherwise "may not" is ambiguous, and could be seen as meaning the same as "must not"

Copy link
Contributor Author

@kojiishi kojiishi Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for the review.

when the UA determined the trimming (kerning) may cause
glyph cut-offs, collisions, or excessive kerning
through glyph bounding box, glyph metrics, or font features,

Unless 'text-spacing-trim' is set to ''space-all''
(or the font has proportional fullwidth punctuation glyphs),
the UA must collapse the space typically associated with such full width glyphs
Expand Down