[css-text-4] auto-phrase #9242
Merged
[css-text-4] auto-phrase #9242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR moves quite a bit of text around, so it's not too easy too review as a source diff. Here are: |
Recast word-boundary-detection:auto() as word-break:auto-phrase, as well as word-boundary-detection:manual as word-break:manual. This allows retiring the word-boundary-detection property. Also, the word-boundary-expansion property needed to gain its own auto-phrase value, since it could no longer depend on word-boundary-detection:auto(). Supporting sections had to be reorganized as well to keep the whole thing coherent. See w3c#7193. Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Since there's no longer a pair of word-boundary-* properties, there's no need to keep the two names related, and the original name was quite a mouthful. 'word-space-transform' is simpler, and better show-cases the similarities with text-transform. Part of w3c#7193 Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Aug 30, 2023
Adjust word-boundary-expansion tests to become word-space-transform tests, renaming them and accounting for the slight behavior difference (timing of the transformation moved from before phase 1 to between phase 1 and 2).
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Aug 30, 2023
Adjust word-boundary-expansion tests to become word-space-transform tests, renaming them and accounting for the slight behavior difference (timing of the transformation moved from before phase 1 to between phase 1 and 2).
This was referenced Sep 1, 2023
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Sep 1, 2023
word-break and word-space-transform: auto-phrase tests (WIP)
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Sep 1, 2023
word-break and word-space-transform: auto-phrase tests
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Sep 1, 2023
word-break and word-space-transform: auto-phrase tests
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Sep 1, 2023
frivoal
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 1, 2023
syntax tests
frivoal
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 1, 2023
Adjust word-boundary-expansion tests to become word-space-transform tests, renaming them and accounting for the slight behavior difference (timing of the transformation moved from before phase 1 to between phase 1 and 2).
frivoal
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 1, 2023
word-break and word-space-transform: auto-phrase tests
frivoal
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 1, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2023
…-drafts#9242, a=testonly Automatic update from web-platform-tests Update css-text tests to match w3c/csswg-drafts#9242 syntax tests -- Update css-text tests to match w3c/csswg-drafts#9242 Adjust word-boundary-expansion tests to become word-space-transform tests, renaming them and accounting for the slight behavior difference (timing of the transformation moved from before phase 1 to between phase 1 and 2). -- Update css-text tests to match w3c/csswg-drafts#9242 word-break and word-space-transform: auto-phrase tests -- Extra css-text tests to match w3c/csswg-drafts#9242 -- Move tests in reference subfolder -- wpt-commits: 9a8dd9aae7bd12896f91bfe1f8bb8111bb00d24d, 40f20b3118ff6a1511e897f89f67a5a850dfe743, 4ed7098104db0a041d7b6ed7dcd4aa6709dec2f3, a91411b722c19700b70e0e22da0cc085420961a3, 63850c62203d786cd7c01d159b5a4ca7be950bb5 wpt-pr: 41712
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Sep 14, 2023
…-drafts#9242, a=testonly Automatic update from web-platform-tests Update css-text tests to match w3c/csswg-drafts#9242 syntax tests -- Update css-text tests to match w3c/csswg-drafts#9242 Adjust word-boundary-expansion tests to become word-space-transform tests, renaming them and accounting for the slight behavior difference (timing of the transformation moved from before phase 1 to between phase 1 and 2). -- Update css-text tests to match w3c/csswg-drafts#9242 word-break and word-space-transform: auto-phrase tests -- Extra css-text tests to match w3c/csswg-drafts#9242 -- Move tests in reference subfolder -- wpt-commits: 9a8dd9aae7bd12896f91bfe1f8bb8111bb00d24d, 40f20b3118ff6a1511e897f89f67a5a850dfe743, 4ed7098104db0a041d7b6ed7dcd4aa6709dec2f3, a91411b722c19700b70e0e22da0cc085420961a3, 63850c62203d786cd7c01d159b5a4ca7be950bb5 wpt-pr: 41712
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
syntax tests
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
Adjust word-boundary-expansion tests to become word-space-transform tests, renaming them and accounting for the slight behavior difference (timing of the transformation moved from before phase 1 to between phase 1 and 2).
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
word-break and word-space-transform: auto-phrase tests
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recast
word-boundary-detection: auto()asword-break: auto-phrase, as well asword-boundary-detection: manualasword-break: manual.This allows retiring the
word-boundary-detectionproperty.Also, the
word-boundary-expansionproperty needed to gain its ownauto-phrasevalue, since it could no longer depend onword-boundary-detection: auto().Since there's no longer a pair of
word-boundary-*properties, there's no need to keep the two names related, and the original name was quite a mouthful.word-space-transformis simpler, and better show-cases the similarities withtext-transform.Supporting sections had to be reorganized as well to keep the whole thing coherent.
This addresses #7193 (and w3c/i18n-activity#1454). It builds upon and is meant to replace #9216 (which itself builds upon and replaces #8974).
(co-authored with @fantasai)
Note: the
<wpt>annotations have not been fully updated yet. Ignore them for now: I'll update the tests and the corresponding<wpt>annotations in the spec once we agree on the behavior described in this PR.