Skip to content

[css-backgrounds-3][css-borders-4] Fixed definition for where box shadows apply #9296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2023
Merged

[css-backgrounds-3][css-borders-4] Fixed definition for where box shadows apply #9296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
171449a
[css-backgrounds-3][css-borders-4] Fixed definition for where box sha…
SebastianZ Sep 3, 2023
09f169f
[css-backgrounds-3] Corrected changes title
SebastianZ Nov 20, 2023
befc123
[css-backgrounds-3] Fixed definition for where box shadows apply
SebastianZ Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions css-backgrounds-3/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ spec:css2; type:value; text:inline-table
spec:css2; type:value; text:table-cell
spec:css2; type:property; text:overflow
spec:css2; type:value; text:visible
spec:css-break-4; type:dfn; text:fragment
spec:css-color-4; type:property; text:color
spec:css-color-4; type:value; text:transparent
spec:selectors-3; type:selector; text: ::first-letter
Expand Down Expand Up @@ -2512,9 +2513,9 @@ Layering, Layout, and Other Details</h4>
and the [=inner shadows=] of an element are drawn immediately above the background of that element
(below the borders and border image, if any).

<p>If an element has multiple boxes, all of them get drop shadows,
but shadows are only drawn where borders would also be drawn;
see 'box-decoration-break'.
<p>Unless otherwise specified, drop shadows are only applied to the [=principal box=].
If the affected box has multiple fragments,
the shadows are applied as specified in 'box-decoration-break'.

<p>Shadows do not trigger scrolling or increase the size of the scrollable area.

Expand Down Expand Up @@ -2569,8 +2570,8 @@ The lists below describe which features from this specification are in each leve
<h2 id="changes">
Changes</h2>

<h3 id="changes-2024-02">
Changes since the 14 February 2024 Candidate Recommendation Snapshot</h3>
<h3 id="changes-2023-02">
Changes since the 14 February 2023 Candidate Recommendation Snapshot</h3>

<ul>
<li>Defined serialization of 'background-position' in [[#bg-position-serialization]].
Expand All @@ -2591,6 +2592,8 @@ Changes since the 14 February 2024 Candidate Recommendation Snapshot</h3>
to include “Animation Type” and “Logical Property Group”.
<li>Streamlined property grammar definitions using the latest
[=CSS/value definition syntax=].
<li>Fixed the definition for where box shadows apply.
(<a href="https://github.com/w3c/csswg-drafts/issues/9286">Issue 9286</a>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the "Changes since the 14 February 2024 Candidate Recommendation Snapshot" which doesn't exist (should be 2023 instead).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether @fantasai's comment was related to this, though I went ahead and fixed this obvious mistake.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I was commenting on the actual spec text.

</ul>


Expand Down
6 changes: 3 additions & 3 deletions css-borders-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,9 +961,9 @@ Layering, Layout, and Other Details</h4>
and the <i>inner shadows</i> of an element are drawn immediately above the background of that element
(below the borders and border image, if any).

<p>If an element has multiple boxes, all of them get drop shadows,
but shadows are only drawn where borders would also be drawn;
see 'box-decoration-break'.
<p>Unless otherwise specified, drop shadows are only applied to the [=principal box=].
If the affected box has multiple fragments,
the shadows are applied as specified in 'box-decoration-break'.

<p>Shadows do not trigger scrolling or increase the size of the scrollable area.

Expand Down