[css-view-transitions-2] Apply renames based on TPAC discussion #9382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@khushalsagar @vmpstr ping? |
vmpstr
reviewed
Sep 27, 2023
| enum ViewTransitionTrigger { "navigation", "none" }; | ||
| [Exposed=Window] | ||
| interface CSSViewTransitionRule : CSSRule { | ||
| readonly attribute CSSOMString navigationConditionText; |
Member
There was a problem hiding this comment.
I'm guessing this is not an enum because eventually we'll have a list of qualifiers here?
Collaborator
Author
There was a problem hiding this comment.
Right. This is consistent with existing conditionText attributes
| </div> | ||
|
|
||
| <div algorithm="monkey patch to rendering"> | ||
| Run the following step in [=update the rendering|updating the renedering=], before [=running the animation frame callbacks=]: |
Collaborator
Author
There was a problem hiding this comment.
Let's review the specifics as part of whatwg/html#9791. Merging for now.
khushalsagar
approved these changes
Sep 27, 2023
Member
khushalsagar
left a comment
There was a problem hiding this comment.
LGTM % bokan.
Btw we should be using semantic line breaks for wrapping but makes sense to do that in a separate PR.
vmpstr
approved these changes
Sep 28, 2023
…w-transition to navigation-behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename based on TPAC conversation: auto-view-transition => view-transition (with
trigger: navigationas the descriptor)Also added CSSOM support for the new rule.
Close #8048 as per TPAC discussion.
Opened #9383 to continue bikeshedding discussion about the at-rule name. We can update the spec once that's finalized.