Skip to content

[css-view-transitions-2] Add transition types #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmpstr merged 11 commits into from
Oct 11, 2023
Merged

[css-view-transitions-2] Add transition types #9385

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a3405ce
Transition types
noamr Sep 20, 2023
b02d663
Update css-view-transitions-2/Overview.bs
noamr Sep 27, 2023
6b8226d
Update css-view-transitions-2/Overview.bs
noamr Sep 27, 2023
20634f6
Semantic line break + remove UpdateCallback
noamr Sep 27, 2023
7c63de3
Update css-view-transitions-2/Overview.bs
noamr Sep 28, 2023
fef8fa0
Update css-view-transitions-2/Overview.bs
noamr Sep 28, 2023
c17085d
Make conds more readable
noamr Sep 28, 2023
04423df
Overload
noamr Oct 2, 2023
51a3dd7
Added example
noamr Oct 3, 2023
24ffc30
Fix union nullness
noamr Oct 6, 2023
d460f9b
nit
noamr Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nit
  • Loading branch information
@noamr
noamr committed Oct 6, 2023
commit d460f9bcfbb292e8e2365018c08f9143802d74c6
4 changes: 2 additions & 2 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,9 @@ The <dfn attribute for=PageRevealEvent>viewTransition</dfn> [=getter steps=] are
<div algorithm="start-vt-with-options">
The [=method steps=] for <dfn method for=Document>startViewTransition(|callbackOptionsOrNull|)</dfn> are as follows:

1. If |callbackOptionsOrNull| is an {{UpdateCallback}} or null, then run the [=method steps=] for {{Document/startViewTransition(updateCallback)}} given |callbackOrOptions| and return the result.
1. If |callbackOptionsOrNull| is an {{UpdateCallback}} or null, then run the [=method steps=] for {{Document/startViewTransition(updateCallback)}} given |callbackOptionsOrNull| and return the result.

Copy link
Member

@vmpstr vmpstr Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the comment above, these steps should also handle both situations by deferring to L1's algorithms as appropriate

Copy link
Collaborator Author

@noamr noamr Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

1. Let |viewTransition| be the result of running [=method steps=] for {{Document/startViewTransition(updateCallback)}} given |callbackOrOptions|'s {{StartViewTransitionOptions/update}}.
1. Let |viewTransition| be the result of running [=method steps=] for {{Document/startViewTransition(updateCallback)}} given |callbackOptionsOrNull|'s {{StartViewTransitionOptions/update}}.

1. Set |transition|'s [=ViewTransition/active types=] to |callbackOptionsOrNull|'s {{StartViewTransitionOptions/types}}.

Expand Down