Skip to content

[css-view-transitions-2] A few minor edits - #9527

Merged
noamr merged 3 commits into
w3c:mainfrom
noamr:vt2-edits
Oct 26, 2023
Merged

[css-view-transitions-2] A few minor edits#9527
noamr merged 3 commits into
w3c:mainfrom
noamr:vt2-edits

Conversation

@noamr

@noamr noamr commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator
  • Specify paint holding
  • Fix missing |transition| var
  • Allow an empty list in the type descriptor

Closes #8888

* Specify paint holding
* Fix missing |transition| var
* Allow an empty list in the type descriptor
@noamr
noamr requested review from khushalsagar and vmpstr October 26, 2023 15:59
Comment thread css-view-transitions-2/Overview.bs Outdated

Note: The process continues in [=setup view transition=], via [=perform pending transition operations=].

1. The user agent should display the currently displayed frame until |newDocument| is [=revealed=], or until its [=active view transition=]'s [=ViewTransition/phase=] is "`done`".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to reason about why we need "or until its [=active view transition=]'s [=ViewTransition/phase=] is "done". Is this for the case where the transition is skipped before reveal? I think that can only happen in the reveal algorithm here anyway which is right before we hit "revealed".

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the document navigates away or an SPA nav is initiated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok cool. Slight suggestion on wording:

The user agent should display the currently displayed frame until either:

  • |newDocument| is [=revealed=]
  • its [=active view transition=]'s [=ViewTransition/phase=] is "done"

Non-normative note to document the cases you mentioned for the second condition.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % this comment.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread css-view-transitions-2/Overview.bs Outdated
@khushalsagar

Copy link
Copy Markdown
Member

Leaving a note about activating the transition after dispatching the reveal event. So authors have a script hook to set up VT names.

@noamr
noamr merged commit c95d80c into w3c:main Oct 26, 2023
@noamr
noamr deleted the vt2-edits branch October 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-view-transitions-2] Hold paint of old Document until new Document draws a frame

2 participants