Skip to content

Conversation

@cdoublev
Copy link
Collaborator

@cdoublev cdoublev commented Nov 2, 2023

Fixes #9494.

Depends on #9480.

Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but also a question about bikeshedding: as we're getting further away from the actual form of the notation "2n+1", it's getting more confusing to refer to the notation. An+B was somewhat understandable, because it pattern-matches against the notation. But <an-b> just seems like weird 1970s computer garbage naming.

Some possible replacements:

  • <An-B> at least helps it parse as three components (a, n, b), rather than two (an, b).
  • <ith> or <index> or something like that
  • other ideas?

UPDATE: Filed the bikeshedding into #9473 (comment)

@cdoublev cdoublev requested a review from fantasai November 21, 2023 11:22
@cdoublev
Copy link
Collaborator Author

Marking this PR as a draft while there are discussions to rename <an-b>.

@cdoublev cdoublev marked this pull request as draft November 21, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-selectors-4] Use actual types in nth pseudo class selectors

2 participants