[css-borders-4][editorial] Moved logical border properties from CSS Logical 1 to CSS Borders 4 #9592
Conversation
There was a problem hiding this comment.
+1 to merging these in, but, I think we should try to integrate them into the spec a bit better, so that they don't feel so tacked on. One of our goals (mine anyway) is to make the logical properties eventually feel like 1st-class citizens alongside the physical ones. Probably should do the same in css-box-4 as well, fwiw.
The existing properties should indeed stay in css-logical-1 ; that spec scopes itself to defining the logical equivalents of all CSS2 properties, and expecting future topical specs to supersede and expand on their relevant logical properties.
…ogical 1 to CSS Borders 4
523dab3 to
8463087
Compare
I tried to improve that by merging the definitions of both the physical and logical ones. Hope that's better now. Note that I did not merge everything from CSS Backgrounds 3 in yet. I plan to do that once the spec. is stable enough. Sebastian |
css-borders-4/Overview.bs
Outdated
| <h3 id="logical-shorthand-keyword"> | ||
| Four-Directional Shorthand Properties: the 'logical' keyword for 'border-width', 'border-style', and 'border-color'</h3> |
There was a problem hiding this comment.
Drop this section, as this issue is being worked out in css-logical. Once that stabilizes, we can add relevant bits of spec text; but probably there will be a central definition that we can link to for these types of shorthands, not one that needs to be copied from spec to spec.
css-borders-4/Overview.bs
Outdated
| The logical properties 'border-block-start-color', 'border-block-end-color', | ||
| 'border-inline-start-color', and 'border-inline-end-color' correspond to the | ||
| 'border-top-color', 'border-bottom-color', 'border-left-color', | ||
| and 'border-right-color' properties. | ||
| The mapping depends on the element's 'writing-mode', 'direction', | ||
| and 'text-orientation'. |
There was a problem hiding this comment.
Rewrap.
| The logical properties 'border-block-start-color', 'border-block-end-color', | |
| 'border-inline-start-color', and 'border-inline-end-color' correspond to the | |
| 'border-top-color', 'border-bottom-color', 'border-left-color', | |
| and 'border-right-color' properties. | |
| The mapping depends on the element's 'writing-mode', 'direction', | |
| and 'text-orientation'. | |
| The [=flow-relative=] properties | |
| 'border-block-start-color', | |
| 'border-block-end-color', | |
| 'border-inline-start-color', | |
| and 'border-inline-end-color' | |
| correspond to the [=physical=] properties | |
| 'border-top-color', | |
| 'border-bottom-color', | |
| 'border-left-color', | |
| and 'border-right-color' properties. | |
| The mapping depends on the element's 'writing-mode', 'direction', and 'text-orientation'. |
Likewise below. Once we start wrapping a list, we usually put each item on a separate line; that makes it straightforward to add/move items.
| <p>The border can either be a predefined style (solid line, double | ||
| line, dotted line, pseudo-3D border, etc.) or it can be an image. In | ||
| the former case, various properties define the style ('border-style'), | ||
| color ('border-color'), and thickness ('border-width') of the border. |
There was a problem hiding this comment.
(This needs rewrapping, but so does the entire css-backgrounds-3 spec, so keeping it corresponding seems fine for now, and we will keep them in sync later after I re-wrap css-backgrounds-3. :) See css-cascade-* for what this looks like, and bin/xcommit.pl for why this is important.)
css-borders-4/Overview.bs
Outdated
| The first value represents the <a>start</a> edge color, | ||
| and the second value represents the <a>end</a> edge color. | ||
| If only one value is given, | ||
| it applies to both the <a>start</a> and <a>end</a> edges. |
There was a problem hiding this comment.
We use "side", not "edge", to refer to the parts of the border. See e.g. https://www.w3.org/TR/css-backgrounds-3/#border-color
There was a problem hiding this comment.
Ok, done. Though Backgrounds 3 (and also Borders 4) still uses "edge" in other places.
…tive border properties being renamed to "logical"
An issue in CSS Borders 4 asked whether we should move the logical border properties from CSS Logical 1 to that spec.
As we generally define logical properties and values in their dedicated specs, these days, I thought it would make sense to do that for them as well. So I went ahead and copied those definitions over and renamed "flow-relative" by "logical" as that's the term that's commonly used in newer specs.
I kept the definitions in CSS Logical 1 untouched for now, though, as CSS Borders 4 is meant to supersede those definitions. (Is there anything I have to do to indicate this?)
Sebastian