Skip to content

[css-view-transitions-2] UA may apply implementation-defined timeout o cross-document view transition #9608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[css-view-transitions-2] UA may apply implementation-defined timeout o cross-document view transition #9608

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9582910
[css-view-transitions-2] UA may apply implementation-defined timeout …
noamr Nov 17, 2023
08c722c
Reword timeout
noamr Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,17 +517,25 @@ The {{CSSViewTransitionRule}} represents a ''@view-transition'' rule.
We explicitly clear it here since the old Document may be cached by the UA.

1. [=Queue a global task=] on the [=DOM manipulation task source=] given |newDocument|'s [=relevant global object=],
to perform the following step:
to perform the following steps:

1. Let |newDocument|'s [=active view transition=] be a new {{ViewTransition}} in |newDocument|'s [=relevant Realm=],
1. Let |inboundTransition| be a new {{ViewTransition}} in |newDocument|'s [=relevant Realm=],
whose [=ViewTransition/named elements=] is |outboundTransition|'s [=ViewTransition/named elements=],
[=ViewTransition/initial snapshot containing block size=] is |outboundTransition|'s [=ViewTransition/initial snapshot containing block size=],
and whose [=ViewTransition/is inbound cross-document transition=] is true.

1. [=Call the update callback=] for |newDocument|'s [=active view transition=].
1. Let |newDocument|'s [=active view transition=] be |inboundTransition|.

1. [=Call the update callback=] for |inboundTransition|.

1. Call |onReady|.

1. At any given time, the UA may decide to skip |inboundTransition|, e.g. after an implementation-defined timeout, by running the following steps:
Copy link
Member

@vmpstr vmpstr Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely need a better term than "At any given time". For example, it can't do it during layout for example, so it's only at a time that a script task can run? I'm not sure if idle time is the right thing or if there is a better term

Copy link
Collaborator Author

@noamr noamr Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script tasks can run during layout. But we can make it so that the steps queue a task.


1. If |transition|'s [=ViewTransition/phase=] is "`done`", then return.

1. [=Skip the view transition=] |transition| with a "{{TimeoutError}}" {{DOMException}}.

Note: |outboundTransition| is not exposed to JavaScript, it is used only for capturing
the state of the old document.

Expand Down