[css-shapes-1] propdef fixes #9722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add this to the shape-margin propdef table, too? |
7433ec9 to
443eac3
Compare
|
@astearns Done. |
astearns
reviewed
Dec 19, 2023
css-shapes-1/Overview.bs
Outdated
| Inherited: no | ||
| Computed value: as <a href="#basic-shape-computed-values">defined</a> for <<basic-shape>> (with <<shape-box>> following, if supplied); else the computed <<image>>; else the keyword as specified | ||
| Animation type: as <a href="#basic-shape-interpolation">defined</a> for <<basic-shape>>, otherwise discrete | ||
| Animation type: by computed value; see <a href="#basic-shape-interpolation">interpolation</a> of <<basic-shape>> |
There was a problem hiding this comment.
I think we need the discrete portion for shapes from image and/or combos of images/basic-shapes etc.
(thought I’d already left this comment, but now I don’t see it)
There was a problem hiding this comment.
I think that's covered here: https://www.w3.org/TR/web-animations/#by-computed-value
There was a problem hiding this comment.
Image to image has the same type and number of components, so does not fit the requirements for discrete animation there.
There was a problem hiding this comment.
Oh, right. I forgot that doesn't animate here the same way as normally. I'll drop that commit.
You might want to close #9009 as rejected.
443eac3 to
5960926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5160