Shapes edits #9723
Merged
Shapes edits #9723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ridden by other specs (like Motion).
…l-size> from Images, per #824
|
Will fix #7390, thanks! |
astearns
reviewed
Dec 19, 2023
| ellipse( [ <<shape-radius>>{2} ]? [ at <<position>> ]? ) | ||
| </dt> | ||
| * The <<radial-size>> argument defines | ||
| the circle's radius. |
There was a problem hiding this comment.
Was there a reason for omitting “Negative values are invalid” here and for ellipse()?
There was a problem hiding this comment.
Already defined as part of the production, which has bounds on the <length-percentage>. It didn't need to be reproduced.
astearns
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up a few long-pending Shapes edits for #9053, #8695, #824, and a Guillaume complaint (about the basic shape grammar definitions not being in a prod) that I can't find the issue number for right now.