Skip to content

[css-view-transitions-1] Refactor timings of updateCallbackDone and related #9774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2024
Merged

[css-view-transitions-1] Refactor timings of updateCallbackDone and related #9774

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e117bf1
[css-view-transitions-1] Fix timings
noamr Jan 8, 2024
f73bcd1
Reinstate one of the done checks
noamr Jan 8, 2024
d398eae
Add note about noop
noamr Jan 8, 2024
80850e5
Reposition note
noamr Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reinstate one of the done checks
  • Loading branch information
@noamr
noamr committed Jan 8, 2024
commit f73bcd1fba07f351a933a1a3b89a43c9ef26ba9d
8 changes: 7 additions & 1 deletion css-view-transitions-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,13 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. [=Queue a global task=] on the [=DOM manipulation task source=],
given |transition|'s [=relevant global object=],
to [=call the update callback=].
to perform the following steps:

1. If |transition|'s [=ViewTransition/phase=] is "`done`", then abort these steps.

Note: This happens if |transition| was [=skip the view transition|skipped=] before this point.

1. [=call the update callback=].

Note: A task is queued here because the texture read back in [=capturing the image=] may be async,
Copy link
Member

@khushalsagar khushalsagar Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind restoring the position of this note? Nicer to have this next to where we post the task. Otherwise its part of this sub-point which is less clearer.

Copy link
Collaborator Author

@noamr noamr Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

although the render steps in the HTML spec act as if it's synchronous.
Expand Down