[css-color] Editorial: correct case for JS 'Math' #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The Sebastian |
Contributor
Author
|
Oh... right... But the sample code here doesn't provide implementations of those, either? Closing this since the suggested change is bogus. |
Contributor
Correct. Those would need to be added to the sample code. Sebastian |
Contributor
Right, that is why it uses the math library to do so :) since that library does provide them. You can look at the code easily, it is in the repo as math.js |
svgeesus
reviewed
Jan 24, 2017
Contributor
svgeesus
left a comment
There was a problem hiding this comment.
This correction is bogus. math is the correct library, not the built-in Math library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.