[css-images-4][editorial] Add wpt annotations, fix #9800 #9801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaVerou
requested changes
Jan 15, 2024
css-images-4/Overview.bs
Outdated
| @@ -240,6 +242,47 @@ Resolution/Type Negotiation: the ''image-set()'' notation {#image-set-notation} | |||
| If not specified, | |||
| it has no effect on the <<image-set-option>>. | |||
|
|
|||
| <wpt> | |||
| image-set/image-set-all-options-invalid.html | |||
| image-set/image-set-calc-x-rendering-2.html | |||
There was a problem hiding this comment.
Looks like there's a formatting issue here?
LeaVerou
approved these changes
Jan 15, 2024
|
Sorry for not reviewing, was on vacation. Looks good, thanks for the review @LeaVerou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3281 tests to the test results.
Note: inline test results are open in this PR, to make checking easier. Editors may well choose to set them to closed after merging this PR
@tabatkins @fantasai @LeaVerou