Skip to content

[css-view-transitions-2] Editorial: fix document variable usage #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noamr merged 1 commit into from
Jan 26, 2024
Merged

[css-view-transitions-2] Editorial: fix document variable usage #9861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ The {{CSSViewTransitionRule}} represents a ''@view-transition'' rule.
Note: this means that any running transition would be skipped when the document is ready
to unload.

1. Set |document|'s [=auto-skip view transitions=] to true.
1. Set |oldDocument|'s [=auto-skip view transitions=] to true.

Note: this means that calling {{Document/startViewTransition()}} while capturing the old document for a cross-document view-transition would run the callback but skip the animation.

Expand All @@ -474,7 +474,7 @@ The {{CSSViewTransitionRule}} represents a ''@view-transition'' rule.
Note: The ViewTransition object on the old Document should be destroyed after its state has been copied to the new Document below.
We explicitly clear it here since the old Document may be cached by the UA.

1. Set |document|'s [=auto-skip view transitions=] to false.
1. Set |oldDocument|'s [=auto-skip view transitions=] to false.

1. [=Queue a global task=] on the [=DOM manipulation task source=] given |newDocument|'s [=relevant global object=],
to perform the following steps:
Expand All @@ -491,7 +491,7 @@ The {{CSSViewTransitionRule}} represents a ''@view-transition'' rule.
1. Call |onReady|.

1. At any given time, the UA may decide to skip |inboundTransition|, e.g. after an [=implementation-defined=] timeout.
To do so, the UA should [=queue a global task=] on the [=DOM manipulation task source=] given |document|'s [=relevant global object=] to perform the following step:
To do so, the UA should [=queue a global task=] on the [=DOM manipulation task source=] given |newDocument|'s [=relevant global object=] to perform the following step:
If |transition|'s [=ViewTransition/phase=] is not "`done`", then [=skip the view transition=] |transition| with a "{{TimeoutError}}" {{DOMException}}.

Note: |outboundTransition| is not exposed to JavaScript, it is used only for capturing
Expand Down