Skip to content

[css-view-transitions-2] Require one or more custom ident for view-transition-class and type #9896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

cdoublev
Copy link
Collaborator

@cdoublev cdoublev commented Feb 2, 2024

The value definitions of view-transition-class and type currently allow an empty value with <custom-ident>*, which means zero or more <custom-ident>:

Name: view-transition-class
Value: none | <custom-ident>*

See this discussion about accepting an empty value in the property value range.

@cdoublev cdoublev added the css-view-transitions-2 View Transitions; New feature requests label Feb 2, 2024
@cdoublev cdoublev changed the title [css-view-transitions-2] Require one or more custom ident for view-transition-class [css-view-transitions-2] Require one or more custom ident for view-transition-class and type Feb 2, 2024
@noamr
Copy link
Collaborator

noamr commented Mar 14, 2024

Hi, do you mind rebasing? I'll be happy to merge it in (for classes, types are already sorted)

@noamr
Copy link
Collaborator

noamr commented Mar 14, 2024

@tabatkins mind marking this as non-substantive for IPR?

@w3cbot
Copy link

w3cbot commented Mar 14, 2024

astearns marked as non substantive for IPR from ash-nazg.

@astearns
Copy link
Member

@cdoublev could you contact me? (email is in my profile, or on irc, or whatever else)

I’d like to see if we can remove the constant IPR checks we have to deal with on your PRs

@noamr noamr merged commit 7b442a7 into w3c:main Mar 15, 2024
@cdoublev cdoublev deleted the pr-9896 branch March 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-view-transitions-2 View Transitions; New feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants