This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Fix flex-grow-006.html #1104
Merged
Fix flex-grow-006.html #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test wants to make sure that "any positive flex factor" grows the flex item to full size, but fractional flex factors < 1 do not do that. Instead, let's use 1.5 here.
Collaborator
Automatic validation checks of commit 8e6c4e1 passed. |
Author
gsnedders
added a commit
to gsnedders/csswg-test
that referenced
this pull request
Aug 5, 2016
This was accidentally tested prior to w3c#1104.
gsnedders
added a commit
to gsnedders/csswg-test
that referenced
this pull request
Oct 31, 2016
This was accidentally tested prior to w3c#1104.
gsnedders
added a commit
to gsnedders/csswg-test
that referenced
this pull request
Jan 24, 2017
This was accidentally tested prior to w3c#1104.
gsnedders
added a commit
to gsnedders/csswg-test
that referenced
this pull request
Mar 25, 2017
This was accidentally tested prior to w3c#1104.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test wants to make sure that "any positive flex factor" grows the flex item to full size, but fractional flex factors < 1 do not do that. Instead, let's use 1.5 here.
This change is