Reference tests for display:contents #1129
Conversation
Automatic validation checks of commit 2c3cd00 discovered the following problems:In css-display-3/display-contents-td-001-ref.html:
In css-display-3/display-contents-replaced-001-ref.html:
In css-display-3/display-contents-block-001-ref.html:
In css-display-3/display-contents-first-line-001-ref.html:
In css-display-3/display-contents-inline-001-ref.html:
In css-display-3/display-contents-tr-001-ref.html:
In css-display-3/display-contents-first-letter-001-ref.html:
In css-display-3/display-contents-before-after-001-ref.html:
|
Automatic validation checks of commit b901323 passed. |
| <link rel="author" title="Rune Lillesveen" href="mailto:rune@opera.com"> | ||
| <p>You should see the word PASS without extra spacing below.</p> | ||
| <table cellpadding="0"> | ||
| <td>PASS</td> |
| </style> | ||
| <p>You should see the word PASS without extra spacing below.</p> | ||
| <table> | ||
| <td>P</td><td>A</td><td>S</td><td>S</td> |
| <link rel="author" title="Rune Lillesveen" href="mailto:rune@opera.com"> | ||
| <p>You should see the word PASS below.</p> | ||
| <table cellpadding="0" cellspacing="0"> | ||
| <td>PASS</td> |
| <title>CSS Reftest Reference</title> | ||
| <link rel="author" title="Rune Lillesveen" href="mailto:rune@opera.com"> | ||
| <p>You should see the word PASS below.</p> | ||
| PASS |
There was a problem hiding this comment.
Can you share reference file more? The first-line and first-letter ones are identical, at least, and most of the others that say "PASS" could be adjusted to be identical and share ref I think.
There was a problem hiding this comment.
I've re-organized a bit to do this. I split the margin-collapsing through display:contents into a separate test (block-002)
| @@ -0,0 +1,16 @@ | |||
| <!DOCTYPE html> | |||
| <meta charset="utf-8"> | |||
| <title>CSS Display: display:contents and ::first-line</title> | |||
There was a problem hiding this comment.
(This test seems to fail in Gecko, though that seems like a bug in Gecko. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1305951 )
| <link rel="help" href="https://drafts.csswg.org/css-display-3/#valdef-display-contents"> | ||
| <link rel="match" href="display-contents-td-001-ref.html"> | ||
| <style> | ||
| td { display: contents } |
There was a problem hiding this comment.
Maybe add more padding so it's very clear when it fails
Automatic validation checks of commit 810299c passed. |
It was not clear to me from the spec what the expected result of applying display:contents to replaced elements is. The added test for replace contents matches what Gecko implemented.
This change is