-
Notifications
You must be signed in to change notification settings - Fork 320
[css-ui] Resolved value of caret-color should be the used value #1161
Conversation
Automatic validation checks of commit a96e1b4 passed. |
As discussed on issue w3c/csswg-drafts#781, I'm updating the tests so that caret-color behaves similar to the rest of color properties.
a96e1b4 to
5b3a864
Compare
Automatic validation checks of commit 5b3a864 passed. |
|
The change look good to me assuming we resolve on w3c/csswg-drafts#566 that for colors the resolved value is the used value. I think we will, but we haven't yet. I'll merge as soon as we do. |
Automatic validation checks of commit b96acae passed. |
frivoal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change assumes we resolve on w3c/csswg-drafts#566 that for colors the resolved value is the used value. The WG just did so, so it looks all good.
|
@gsnedders (CC @plinss @astearns @atanassov) I want to merge this pull request, but "the system" is getting in the way:
I am sure that I am missing something, but this is a nuisance. So either the failure is caused by a real problem that needs to be address, in which case we need to make it much clearer what that problem is so that I know what I need to do, or it is not, and we need to get these annoyances out of the way. |
Automatic validation checks of commit 984848a passed. |
I've fixed this in #1164.
I'm not completely sure that I'm right but trying to reply with my guesses. 😄 |
Thanks. I had updated the branch to get the latest from master, but I had not fixed master first. However it is that broken commits are getting into master, we should stop that. Or we should fix travis to only block on new errors introduced in the pull request, not those already present in master. |
As discussed on issue w3c/csswg-drafts#781, I'm updating the tests
so that caret-color behaves similar to the rest of color properties.
This change is