Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Conversation

@mrego
Copy link
Member

@mrego mrego commented Dec 14, 2016

As discussed on issue w3c/csswg-drafts#781, I'm updating the tests
so that caret-color behaves similar to the rest of color properties.


This change is Reviewable

@syncbot
Copy link
Collaborator

syncbot commented Dec 14, 2016

Automatic validation checks of commit a96e1b4 passed.

As discussed on issue w3c/csswg-drafts#781, I'm updating the tests
so that caret-color behaves similar to the rest of color properties.
@mrego mrego force-pushed the caret-color-resolved-value branch from a96e1b4 to 5b3a864 Compare December 14, 2016 10:06
@syncbot
Copy link
Collaborator

syncbot commented Dec 14, 2016

Automatic validation checks of commit 5b3a864 passed.

@mrego mrego requested a review from frivoal December 14, 2016 15:28
@mrego mrego self-assigned this Dec 14, 2016
@frivoal
Copy link

frivoal commented Dec 14, 2016

The change look good to me assuming we resolve on w3c/csswg-drafts#566 that for colors the resolved value is the used value. I think we will, but we haven't yet. I'll merge as soon as we do.

@syncbot
Copy link
Collaborator

syncbot commented Dec 21, 2016

Automatic validation checks of commit b96acae passed.

Copy link

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change assumes we resolve on w3c/csswg-drafts#566 that for colors the resolved value is the used value. The WG just did so, so it looks all good.

@frivoal
Copy link

frivoal commented Dec 22, 2016

@gsnedders (CC @plinss @astearns @atanassov) I want to merge this pull request, but "the system" is getting in the way:

  1. What's up with this failling / stalling travis CI checks? Are they doing anything valuable? Cause all I see them do is fail on perfectly reasonable pull requests and get in the way.
  2. Why does github keep on insisting that branches are too old, and that I need to merge master into it? This is a clean merge, and the vast majority of the things in that repo are independent from eachother, so the risk of having issues due to an old branching point are minimal. I wouldn't necessarily mind doing the update anyway, except that it triggers a lengthy and often (randomly?) failing travis run.

I am sure that I am missing something, but this is a nuisance. So either the failure is caused by a real problem that needs to be address, in which case we need to make it much clearer what that problem is so that I know what I need to do, or it is not, and we need to get these annoyances out of the way.

@syncbot
Copy link
Collaborator

syncbot commented Dec 22, 2016

Automatic validation checks of commit 984848a passed.

@mrego
Copy link
Member Author

mrego commented Dec 22, 2016

  1. What's up with this failling / stalling travis CI checks? Are they doing anything valuable? Cause all I see them do is fail on perfectly reasonable pull requests and get in the way.

I've fixed this in #1164.

  1. Why does github keep on insisting that branches are too old, and that I need to merge master into it? This is a clean merge, and the vast majority of the things in that repo are independent from eachother, so the risk of having issues due to an old branching point are minimal. I wouldn't necessarily mind doing the update anyway, except that it triggers a lengthy and often (randomly?) failing travis run.

I'm not completely sure that I'm right but trying to reply with my guesses. 😄
I guess that if master was broken when you start the PR, even if it's fixed later, you'll still get that Travis CI doesn't pass. That's why GitHub offers you the chance to Update branch and get the last commits from master.
I just did it and now Travis CI is happy.

@mrego mrego merged commit ddd614b into w3c:master Dec 22, 2016
@frivoal
Copy link

frivoal commented Dec 22, 2016

I just did it and now Travis CI is happy.

Thanks. I had updated the branch to get the latest from master, but I had not fixed master first.

However it is that broken commits are getting into master, we should stop that. Or we should fix travis to only block on new errors introduced in the pull request, not those already present in master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants