-
Notifications
You must be signed in to change notification settings - Fork 322
[css-grid] Add more tests for Implied Minimum Size of Grid Items section #1199
Conversation
This adds more coverage for that spec section: https://drafts.csswg.org/css-grid/#min-size-auto The examples in the tests were discussed in w3c/csswg-drafts#283.
Automatic validation checks of commit 283588f discovered the following problems:In css-grid-1/grid-items/grid-minimum-size-grid-items-016.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-014.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-012.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-013.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-015.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-011.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-010.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-017.html:
In css-grid-1/grid-items/grid-minimum-size-grid-items-018.html:
|
Automatic validation checks of commit 5c38777 passed. |
I thought |
Wouldn't be better to use red as "test-grid-item-overlapping-xxx" background so we see red only it it overflows ? Review status: 0 of 9 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 8 of 9 files at r2. css-grid-1/grid-items/grid-minimum-size-grid-items-011.html, line 7 at r2 (raw file):
I guess this test will verify the item is stretched to fill the 500px x 500px grid, so does it makes sense to test if it overflows ? Comments from Reviewable |
Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion. css-grid-1/grid-items/grid-minimum-size-grid-items-011.html, line 7 at r2 (raw file): Previously, javifernandez (Javier Fernandez Garcia-Boente) wrote…
No, this patch the grid item is no bigger than 100x100. Comments from Reviewable |
I could change that, that will show "red" if the item overflows. Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
Ok, I understand. Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
Reviewed 1 of 9 files at r2. Comments from Reviewable |
This adds more coverage for that spec section:
https://drafts.csswg.org/css-grid/#min-size-auto
The examples in the tests were discussed in w3c/csswg-drafts#283.
Please @javifernandez or @svillar take a look. Thanks!
This change is