This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Fix flex-margin-no-collapse.html #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in https://lists.w3.org/Archives/Public/www-style/2015Mar/0463.html, the testcase is broken. This patch adds flex:none so that it displays correctly; this seems to match the intention better than the alternative of changing the container's height to 400px. Without this change, the boxes will shrink due to the flexing and not cover up the red box.
Automatic validation checks of commit d6cb42e passed. |
|
LGTM. |
mrego
added a commit
that referenced
this pull request
Mar 27, 2015
Fix flex-margin-no-collapse.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://lists.w3.org/Archives/Public/www-style/2015Mar/0463.html, the testcase is broken. This patch adds flex:none so that it displays correctly; this seems to match the intention better than the alternative of changing the container's height to 400px. Without this change, the boxes will shrink due to the flexing and not cover up the red box.