Skip to content

chore: minimum required Node.js version is 10.13.0 #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2020
Merged

chore: minimum required Node.js version is 10.13.0 #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01766a1
chore: minimum required Node.js version is `10.13.0`
alexander-akait Jul 15, 2020
a502552
ci: remove node@8
alexander-akait Jul 15, 2020
b8093af
test: update snapshots
alexander-akait Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,9 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [8.x, 10.x, 12.x, 14.x]
node-version: [10.x, 12.x, 14.x]
webpack-version: [latest, next]

exclude:
# Webpack 5 does not support node 8
- node-version: 8.x
webpack-version: next

runs-on: ${{ matrix.os }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = (api) => {
'@babel/preset-env',
{
targets: {
node: '8.9.0',
node: '10.13.0',
},
},
],
Expand Down
3,663 changes: 1,748 additions & 1,915 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 16 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"main": "dist/cjs.js",
"engines": {
"node": ">= 8.9.0"
"node": ">= 10.13.0"
},
"scripts": {
"start": "npm run build -- -w",
Expand Down Expand Up @@ -43,10 +43,10 @@
"webpack": "^4.0.0 || ^5.0.0"
},
"dependencies": {
"camelcase": "^5.3.1",
"camelcase": "^6.0.0",
"cssesc": "^3.0.0",
"icss-utils": "^4.1.1",
"loader-utils": "^1.2.3",
"loader-utils": "^2.0.0",
"normalize-path": "^3.0.0",
"postcss": "^7.0.32",
"postcss-modules-extract-imports": "^2.0.0",
Expand All @@ -55,36 +55,36 @@
"postcss-modules-values": "^3.0.0",
"postcss-value-parser": "^4.1.0",
"schema-utils": "^2.7.0",
"semver": "^6.3.0"
"semver": "^7.3.2"
},
"devDependencies": {
"@babel/cli": "^7.10.1",
"@babel/core": "^7.10.2",
"@babel/preset-env": "^7.10.2",
"@commitlint/cli": "^8.3.5",
"@commitlint/config-conventional": "^8.3.4",
"@babel/cli": "^7.10.5",
"@babel/core": "^7.10.5",
"@babel/preset-env": "^7.10.4",
"@commitlint/cli": "^9.1.2",
"@commitlint/config-conventional": "^9.1.1",
"@webpack-contrib/defaults": "^6.3.0",
"@webpack-contrib/eslint-config-webpack": "^3.0.0",
"babel-jest": "^25.5.1",
"babel-jest": "^26.1.0",
"cross-env": "^7.0.2",
"del": "^5.1.0",
"del-cli": "^3.0.1",
"es-check": "^5.1.0",
"eslint": "^6.8.0",
"eslint": "^7.4.0",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-import": "^2.21.2",
"eslint-plugin-import": "^2.22.0",
"file-loader": "^6.0.0",
"husky": "^4.2.5",
"jest": "^25.5.4",
"jest": "^26.1.0",
"lint-staged": "^10.2.11",
"memfs": "^3.2.0",
"npm-run-all": "^4.1.5",
"postcss-loader": "^3.0.0",
"postcss-preset-env": "^6.7.0",
"prettier": "^2.0.5",
"sass": "^1.26.8",
"sass-loader": "^8.0.2",
"standard-version": "^8.0.0",
"sass": "^1.26.10",
"sass-loader": "^9.0.2",
"standard-version": "^8.0.2",
"strip-ansi": "^6.0.0",
"url-loader": "^4.1.0",
"webpack": "^4.43.0"
Expand Down
16 changes: 8 additions & 8 deletions test/__snapshots__/esModule-option.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,10 @@ var ___CSS_LOADER_EXPORT___ = ___CSS_LOADER_API_IMPORT___(false);
___CSS_LOADER_EXPORT___.i(___CSS_LOADER_AT_RULE_IMPORT_0___);
var ___CSS_LOADER_URL_REPLACEMENT_0___ = ___CSS_LOADER_GET_URL_IMPORT___(___CSS_LOADER_URL_IMPORT_0___);
// Module
___CSS_LOADER_EXPORT___.push([module.id, \\"@charset \\\\\\"UTF-8\\\\\\";\\\\n\\\\n/* Comment */\\\\n\\\\n._3S58jeCkC6SOPhVLbU-Bwn {\\\\n color: red;\\\\n background: url(\\" + ___CSS_LOADER_URL_REPLACEMENT_0___ + \\");\\\\n}\\\\n\\", \\"\\"]);
___CSS_LOADER_EXPORT___.push([module.id, \\"@charset \\\\\\"UTF-8\\\\\\";\\\\n\\\\n/* Comment */\\\\n\\\\n._2uMy1nigdepJE7b3T1Visj {\\\\n color: red;\\\\n background: url(\\" + ___CSS_LOADER_URL_REPLACEMENT_0___ + \\");\\\\n}\\\\n\\", \\"\\"]);
// Exports
___CSS_LOADER_EXPORT___.locals = {
\\"class\\": \\"_3S58jeCkC6SOPhVLbU-Bwn\\"
\\"class\\": \\"_2uMy1nigdepJE7b3T1Visj\\"
};
export default ___CSS_LOADER_EXPORT___;
"
Expand All @@ -163,7 +163,7 @@ exports[`"esModule" option should work with a value equal to "true" and the "mod
Array [
Array [
"../../src/index.js?[ident]!./es-module/imported.css",
"._3xfjtZ03Dx7Cld7Debi-wl {
"._3zJoIAkhorFsUbhn0phThb {
color: red;
}
",
Expand All @@ -175,7 +175,7 @@ Array [

/* Comment */

._3S58jeCkC6SOPhVLbU-Bwn {
._2uMy1nigdepJE7b3T1Visj {
color: red;
background: url(/webpack/public/path/img.png);
}
Expand All @@ -199,10 +199,10 @@ var ___CSS_LOADER_EXPORT___ = ___CSS_LOADER_API_IMPORT___(false);
___CSS_LOADER_EXPORT___.i(___CSS_LOADER_AT_RULE_IMPORT_0___);
var ___CSS_LOADER_URL_REPLACEMENT_0___ = ___CSS_LOADER_GET_URL_IMPORT___(___CSS_LOADER_URL_IMPORT_0___);
// Module
___CSS_LOADER_EXPORT___.push([module.id, \\"@charset \\\\\\"UTF-8\\\\\\";\\\\n\\\\n/* Comment */\\\\n\\\\n._3S58jeCkC6SOPhVLbU-Bwn {\\\\n color: red;\\\\n background: url(\\" + ___CSS_LOADER_URL_REPLACEMENT_0___ + \\");\\\\n}\\\\n\\", \\"\\"]);
___CSS_LOADER_EXPORT___.push([module.id, \\"@charset \\\\\\"UTF-8\\\\\\";\\\\n\\\\n/* Comment */\\\\n\\\\n._2uMy1nigdepJE7b3T1Visj {\\\\n color: red;\\\\n background: url(\\" + ___CSS_LOADER_URL_REPLACEMENT_0___ + \\");\\\\n}\\\\n\\", \\"\\"]);
// Exports
___CSS_LOADER_EXPORT___.locals = {
\\"class\\": \\"_3S58jeCkC6SOPhVLbU-Bwn\\"
\\"class\\": \\"_2uMy1nigdepJE7b3T1Visj\\"
};
export default ___CSS_LOADER_EXPORT___;
"
Expand All @@ -212,7 +212,7 @@ exports[`"esModule" option should work with a value equal to "true" and the "mod
Array [
Array [
"../../src/index.js?[ident]!./es-module/imported.css",
"._3xfjtZ03Dx7Cld7Debi-wl {
"._3zJoIAkhorFsUbhn0phThb {
color: red;
}
",
Expand All @@ -224,7 +224,7 @@ Array [

/* Comment */

._3S58jeCkC6SOPhVLbU-Bwn {
._2uMy1nigdepJE7b3T1Visj {
color: red;
background: url(/webpack/public/path/img.png);
}
Expand Down
4 changes: 2 additions & 2 deletions test/__snapshots__/loader.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ exports[`loader should work with the "modules.auto" option and the "importLoader
color: #333;
}
/* CSS modules */
.dA97I-anu7-0d9tFzAFON {
._3ZewTmcU5fqs585BjdQt_0 {
overflow-x: hidden;
overflow-y: auto;
overflow: hidden auto;
Expand All @@ -634,7 +634,7 @@ exports[`loader should work with the "modules.auto" option and the "importLoader
overflow-y: auto;
overflow: hidden auto;
}
._2qRovssCxTKx1PYTv5qdNp {
.irHrhsl3WEJVKUxOmS7dC {
color: #333;
overflow-x: hidden;
overflow-y: auto;
Expand Down
Loading