Skip to content

Added extra example for url.filter for a common scenario #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

dovidweisz
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Provide an example for a common scenario (webpack/webpack#15499).

I'm assuming this updates the docs at https://webpack.js.org/loaders/css-loader/#object-1. If this is not the case, please point me in the right direction.

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dovidweisz / name: D[oa]vid Weisz (3b4465b)

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1428 (aa7dbfb) into master (830fe2c) will not change coverage.
The diff coverage is n/a.

❗ Current head aa7dbfb differs from pull request most recent head b72ea70. Consider uploading reports for the commit b72ea70 to get more accurate results

@@           Coverage Diff           @@
##           master    #1428   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          12       12           
  Lines        1131     1131           
  Branches      411      411           
=======================================
  Hits         1095     1095           
  Misses         27       27           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830fe2c...b72ea70. Read the comment docs.

@dovidweisz
Copy link
Contributor Author

I rebased my changes to make the commit messages conform with the standard.

Are we able to run the checks again?

@alexander-akait alexander-akait merged commit 71d317e into webpack-contrib:master Mar 24, 2022
@alexander-akait
Copy link
Member

Thanks!

@dovidweisz
Copy link
Contributor Author

Cool

When with the docs get updated?

@alexander-akait
Copy link
Member

In near future, we have bots for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants