Skip to content

Replace deprecated String.prototype.substr() #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Replace deprecated String.prototype.substr() #1429

merged 1 commit into from
Mar 17, 2022

Conversation

CommanderRoot
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() or String.prototype.substring() which work similarily but aren't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1429 (ee1624a) into master (830fe2c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          12       12           
  Lines        1131     1131           
  Branches      411      411           
=======================================
  Hits         1095     1095           
  Misses         27       27           
  Partials        9        9           
Impacted Files Coverage Δ
src/utils.js 94.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830fe2c...ee1624a. Read the comment docs.

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@alexander-akait alexander-akait merged commit 5e6cf91 into webpack-contrib:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants