Prefix hashes with underscores based on CSS spec #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the CSS spec, identifiers cannot start with a digit, two hyphens, or a hyphen followed by a digit.
|
Thanks |
|
@sokra are you happy for me to release this as a patch update? |
| @@ -12,5 +12,5 @@ module.exports = function getLocalIdent(loaderContext, localIdentName, localName | |||
| options.content = options.hashPrefix + request + "+" + localName; | |||
| localIdentName = localIdentName.replace(/\[local\]/gi, localName); | |||
| var hash = loaderUtils.interpolateName(loaderContext, localIdentName, options); | |||
| return hash.replace(new RegExp("[^a-zA-Z0-9\\-_\u00A0-\uFFFF]", "g"), "-").replace(/^([^a-zA-Z_])/, "_$1"); | |||
| return hash.replace(new RegExp("[^a-zA-Z0-9\\-_\u00A0-\uFFFF]", "g"), "-").replace(/^((-?[0-9])|--)/, "_$1"); | |||
There was a problem hiding this comment.
@markdalgleish You can simplify the regex to /^(-?\d|--)/
|
it's a minor release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CSS spec, "identifiers cannot start with a digit, two hyphens, or a hyphen followed by a digit" (Source)
The current regular expression doesn't quite follow the spec, leading to unnecessary prefixing. I noticed this when using the
[emoji]placeholder inlocalIdentName. Every emoji was being prefixed with an underscore, despite Glen Maddern's site proving to the world that a single emoji is a valid class name.Also, I noticed that this prefixing behaviour was currently untested, so I've added some test cases for the new regular expression to show how it works in practice.
cc @geelen