Skip to content

Enable getLocalIdent in global options #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hh9527
Copy link

@hh9527 hh9527 commented Dec 14, 2016

What kind of change does this PR introduce?

This PR will enable global options, and thus can give a workaround to #389 : just put getLocalIdent in global options via LoaderOptionsPlugin

Did you add tests for your changes?

Yes, in my project, I use a patch to this loader, and works fine.

If relevant, did you update the README?

Not yet. cause it still has space to improve: enable other options in global. but it should be judged by project owner.

Summary

See above.

#389

Does this PR introduce a breaking change?

No

Other information

This will make it possible to work with webpack2 and extract-text-webpack-plugin

@jsf-clabot
Copy link

jsf-clabot commented Dec 14, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@codecov-io
Copy link

codecov-io commented Dec 14, 2016

Current coverage is 98.36% (diff: 100%)

Merging #391 into master will increase coverage by 0.01%

@@             master       #391   diff @@
==========================================
  Files             9          9          
  Lines           304        306     +2   
  Methods          41         41          
  Messages          0          0          
  Branches         67         69     +2   
==========================================
+ Hits            299        301     +2   
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last update 08e9d47...d71bc76

@gustavohenke
Copy link

gustavohenke commented Dec 29, 2016

Did you add tests for your changes?

Yes, in my project, I use a patch to this loader, and works fine.

"tests" generally means unit tests in GitHub projects

@timse
Copy link

timse commented Jan 21, 2017

I think what you are trying to fix can be solved by adding "ident" to you loaders options. (which may or may not be automatic soon :)).

@michael-ciniawsky
Copy link
Member

I think what you are trying to fix can be solved by adding "ident" to you loaders options.

@timse can you confirm this ? :)

@michael-ciniawsky
Copy link
Member

See reply #389, this should be fixed now :) thx

@michael-ciniawsky michael-ciniawsky removed their assignment Apr 18, 2017
@michael-ciniawsky michael-ciniawsky removed their request for review April 18, 2017 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants