-
-
Notifications
You must be signed in to change notification settings - Fork 608
refactor: evaluate values before extracting imports #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
- Coverage 98.4% 98.35% -0.06%
==========================================
Files 9 9
Lines 314 304 -10
Branches 71 67 -4
==========================================
- Hits 309 299 -10
Misses 5 5
Continue to review full report at Codecov.
|
@simlrh Coud you please close and reopen the PR to trigger the CLA Bot again it should work now 😛 . Would this be a breaking change under any circumstances? |
@simlrh friendly ping 😛 |
Thought this was a different PR. I'm not sure about breaking things. Since you get different behaviour with this than before, it's possible someone is relying on the old behaviour. |
@simlrh @evilebottnawi @bebraw @d3viant0ne Since we intend to remove CSS Modules from |
/cc @michael-ciniawsky seems as breaking changes, It would be better to add a temporary option to enable this (before we drop |
Closing since we don't intend to support CSS Modules in |
What kind of change does this PR introduce?
Applies postcss-modules-values before postcss-modules-extract-imports, in order to allow code such as:
Did you add tests for your changes?
Yes