Skip to content

feat(plugins/url): add url() filter support (options.url) #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Jan 5, 2018

Issues

Notable Changes

url

{Boolean} (default: true)

webpack.config.js

{
  loader: 'css-loader',
  options: {
    url: false
  }
}

{RegExp}

webpack.config.js

{
  loader: 'css-loader',
  options: {
    url: /filter/
  }
}

{Function}

webpack.config.js

{
  loader: 'css-loader',
  options: {
    url (url) {
      return /filter/.test(url)
    }
  }
}

@michael-ciniawsky michael-ciniawsky added this to the 1.0.0 milestone Jan 5, 2018
@michael-ciniawsky michael-ciniawsky changed the title feat(url): add url() filter support (options.url) [WIP] feat(url): add url() filter support (options.url) Jan 5, 2018
@michael-ciniawsky michael-ciniawsky changed the title [WIP] feat(url): add url() filter support (options.url) feat(url): add url() filter support (options.url) Jan 8, 2018
@@ -88,6 +89,32 @@ To disable `url()` resolving by `css-loader` set the option to `false`
}
```

#### `{RegExp}`
Copy link

@stereokai stereokai Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few words about what these options do would be smashing!
@d3viant0ne @michael-ciniawsky

Copy link
Member Author

@michael-ciniawsky michael-ciniawsky Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah yeah :) I intend to add appropriate documentation before this goes anywhere, it hasn't even been signed-off by other maintainers nor released yet... 😛

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, was already hoping to use it today 😆 😭

@bmfs
Copy link

bmfs commented Jun 6, 2018

What is the hold on this, or what are the alternatives for achieving this?

@SergeyKharchenko
Copy link

@bmfs +100

@SergeyKharchenko
Copy link

SergeyKharchenko commented Jun 18, 2018

@michael-ciniawsky, when can we expect this publicly?

@unformatt
Copy link

+1

3 similar comments
@randalpinto
Copy link

+1

@alekaizer
Copy link

+1

@slint
Copy link

slint commented Dec 4, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants