Skip to content

fix(css-base): use content_ instead of content (#674) #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Arvnox
Copy link

@Arvnox Arvnox commented Feb 6, 2018

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
No, there isn't any new functionality.

If relevant, did you update the README?
Not relevant.

Summary
When using the library in WebSphere Portal within a ScriptPortlet, it throws an exception because the name of a local variable (inside a function) is a reserved word in the WCM of WebSphere Portal. This is the reported issue:
#674

Does this PR introduce a breaking change?
No, since it's a local variable.

Other information

@jsf-clabot
Copy link

jsf-clabot commented Feb 6, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ANDRES SARMIENTO TOBON seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Can you provide minimum reproducible steps?

@michael-ciniawsky michael-ciniawsky changed the title fix: use content_ insead of content (#674) fix(css-base): use content_ insead of content (#674) Feb 14, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only specific to your particular setup, I have to decline this PR, but curious if this is/can be made a general case/problem

@michael-ciniawsky
Copy link
Member

You also in any case need to sign the CLA please (close and reopen the PR to trigger the CLA Bot again)

@alexander-akait
Copy link
Member

@michael-ciniawsky let's close this PR

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Feb 14, 2018

@evilebottnawi The stage is yours 😛 (=> feel free to close it)

@michael-ciniawsky michael-ciniawsky changed the title fix(css-base): use content_ insead of content (#674) fix(css-base): use content_ instead of content (#674) Feb 14, 2018
@alexander-akait
Copy link
Member

Declined. Please search other solution to solve this problem. Sorry we should not change code for specific use case. In other env _content variable also may be a reserved word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants