Skip to content

fix(getLocalIdent): add rootContext support (webpack >= v4.0.0) #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2018
Merged

fix(getLocalIdent): add rootContext support (webpack >= v4.0.0) #681

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1819641
Make compatible with webpack 4 rootContext
yavorsky Feb 21, 2018
7ba18a3
Wrap condition in curly brackets
yavorsky Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make compatible with webpack 4 rootContext
  • Loading branch information
@yavorsky
yavorsky committed Feb 21, 2018
commit 1819641df987bebc024e2dbb0e6340d283c2196b
8 changes: 7 additions & 1 deletion lib/getLocalIdent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ var path = require("path");

module.exports = function getLocalIdent(loaderContext, localIdentName, localName, options) {
if(!options.context)
options.context = loaderContext.options && typeof loaderContext.options.context === "string" ? loaderContext.options.context : loaderContext.context;
if (loaderContext.rootContext) {
options.context = loaderContext.rootContext;
} else if (loaderContext.options && typeof loaderContext.options.context === "string") {
options.context = loaderContext.options.context;
} else {
options.context = loaderContext.context;
}
var request = path.relative(options.context, loaderContext.resourcePath);
options.content = options.hashPrefix + request + "+" + localName;
localIdentName = localIdentName.replace(/\[local\]/gi, localName);
Expand Down