Skip to content

docs(readme): add an example how to @import a node module #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

danny-andrews-snap
Copy link
Contributor

@danny-andrews-snap danny-andrews-snap commented Sep 28, 2018

The syntax for importing a node module is not easy to find (see webpack/webpack#1789 (comment)). Maybe this will help a few people out.

What kind of change does this PR introduce?
Dcoumentation

The syntax for importing a node_module is not easy to find (see webpack/webpack#1789 (comment)). Maybe this will help a few people out.
@jsf-clabot
Copy link

jsf-clabot commented Sep 28, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title Add example of @import'ing a node module docs(readme): add an example how to @import a node module Sep 28, 2018
@danny-andrews-snap
Copy link
Contributor Author

@michael-ciniawsky how does it look, now?

@alexander-akait alexander-akait merged commit fb457e5 into webpack-contrib:master Nov 23, 2018
@danny-andrews-snap danny-andrews-snap deleted the patch-1 branch November 26, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants