Skip to content

Refactor loader #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Refactor loader #825

merged 3 commits into from
Nov 29, 2018

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Merge two files in one for better maintenance.

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #825 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   98.51%   98.48%   -0.04%     
==========================================
  Files          11       10       -1     
  Lines         403      395       -8     
  Branches       97       95       -2     
==========================================
- Hits          397      389       -8     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️
lib/utils.js 91.66% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9327c0...d34887b. Read the comment docs.

@alexander-akait alexander-akait merged commit ee409c5 into master Nov 29, 2018
@alexander-akait alexander-akait deleted the refactor-loader branch November 29, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant