Fix broken composition with class names that contain characters other than [A-Za-z0-9_] #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! |
|
This would really help out a project we're working on at Uber! Please let us know if we can do anything to help get this merged, or anything you'd like changed before we do that. +1 |
|
+1 |
|
.über |
markdalgleish
added a commit
that referenced
this pull request
Jul 14, 2015
Fix broken composition with class names that contain characters other than [A-Za-z0-9_]
|
Merged, published as v0.5.14. Thanks for the extremely tidy PR 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class composition is broken with "non-word" (
\w) characters due to the regex used to split tokens.Perfectly valid classes such as
.my-classor.myclässare broken as they get split up.This PR updates the regex to use
\Sinstead of\wwhich allows these characters and thus fixes the problem.Additionally, a test has been added to verify composition works with a class that contains a hyphen (which fails without the updated regex).