fix: no template for dependency error #1058
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
An error would thrown when CSS module called in an EJS Template, like this.
After hours of debugging, I found out that
CssDependencyTemplate
is not injected todependencyTemplates
which assigned to theCompilation
object for generating the code.I moved the injection hook from
thisCompilation
tocompilation
to apply the template to allCompilation
objects.Breaking Changes
Additional Info