Skip to content

fix(index): correct order of CSS imports #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix(index): correct order of CSS imports #242

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7564bdf
Fix sorting of undefined moduleIndex
Aug 13, 2018
78b8dd9
Remove unwanted changes
Aug 13, 2018
8e48ba8
fix: linting
Aug 13, 2018
cf07a43
fix: revert unwanted changes
Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unwanted changes
  • Loading branch information
Jarand Millett committed Aug 13, 2018
commit 78b8dd9b8eabeccab8dba6cbf30620d69ea0b0ca
2 changes: 0 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,6 @@ class MiniCssExtractPlugin {
// with different order this can lead to wrong order
// but it's not possible to create a correct order in
// this case. Don't share chunks if you don't like it.


const [chunkGroup] = chunk.groupsIterable;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only the first chunkGroup is used. Maybe this need to be reconsidered. See also comment above.

if (typeof chunkGroup.getModuleIndex2 === 'function') {
modules.sort(
Expand Down