test: fix jest config and rename files
#258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm 5.6.0 wants to lock transient deps with exact versions which makes sense
As far as I can tell, this should be 2.css, not 3.css as there's no possible source file for it otherwise.
Webpack seems to have had recent changes which change how contenthash is calculated for js files.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change some tests to get them to work which I assume is because they weren't being run in the first place so weren't up-to-date. Details are in the commit messages.
Updated
package-lock.jsonThe package-lock was also updated by npm (I just ran
npm install). The caret dependencies likely caused a version mismatch on Webpack which made the test output different. Lock files shouldn't be using caret dependencies anyway since it defeats the point of a lock file which is to lock down specific transient versions. I'm not sure why npm was using carets in the first place, possibly from an older version. I'm usingnpm@5.6.0.To ensure it's still correct, someone else might want to run them on their machine.
Fixed linting errors
Did this later as didn't see the CircleCI analysis step.
Type
Issues
SemVer