Skip to content

Avoid this[MODULE_TYPE] is not a function error #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

MoOx
Copy link

@MoOx MoOx commented Nov 26, 2018

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Following #73 (comment)

Breaking Changes

No

Additional Info

I didn't add a test because I made this fix from GitHub UI :)

@jsf-clabot
Copy link

jsf-clabot commented Nov 26, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ MoOx
❌ naoisegolden

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, need fix linter problems

Copy link

@naoisegolden naoisegolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the two changes giving a linter error. Accepting them should bring the PR to green.

naoisegolden and others added 2 commits December 18, 2018 18:10
Co-Authored-By: MoOx <git@moox.io>
Co-Authored-By: MoOx <git@moox.io>
@alexander-akait
Copy link
Member

Sorry for delay, fixed in master since v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants