Skip to content

fix: removed unused hmr option #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2020
Merged

fix: removed unused hmr option #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/loader-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
"esModule": {
"type": "boolean"
},
"hmr": {
"type": "boolean"
},
"modules": {
"type": "object",
"additionalProperties": false,
Expand Down
5 changes: 0 additions & 5 deletions test/__snapshots__/validate-loader-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ exports[`validate options should throw an error on the "esModule" option with "1
- options.esModule should be a boolean."
`;

exports[`validate options should throw an error on the "hmr" option with "1" value 1`] = `
"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
- options.hmr should be a boolean."
`;

exports[`validate options should throw an error on the "modules" option with "{"namedExport":"false"}" value 1`] = `
"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
- options.modules.namedExport should be a boolean.
Expand Down
4 changes: 0 additions & 4 deletions test/validate-loader-options.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ describe('validate options', () => {
success: [true, false],
failure: [1],
},
hmr: {
success: [true, false],
failure: [1],
},
modules: {
success: [{ namedExport: true }, { namedExport: false }],
failure: ['true', { namedExport: 'false' }],
Expand Down