Skip to content

support incremental build #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2018
Merged

support incremental build #72

merged 1 commit into from
Mar 29, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 29, 2018

This does NOT include HMR support.

It makes incremental builds possible but doesn't integrate with HMR. So for HMR, CSS will not reload.

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #72   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         180   199   +19     
  Branches       39    43    +4     
====================================
- Misses        141   157   +16     
- Partials       39    42    +3
Impacted Files Coverage Δ
src/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f379ee1...117b40d. Read the comment docs.

src/index.js Outdated
@@ -61,6 +65,17 @@ class CssModule extends webpack.Module {
return resource;
}

updateCacheModule(module) {
console.log('updateCacheModule', module.content);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is require?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@sokra sokra force-pushed the bugfix/incremental-build branch from a05901d to 117b40d Compare March 29, 2018 15:38
@sokra sokra merged commit 7141c9a into master Mar 29, 2018
@alexander-akait alexander-akait deleted the bugfix/incremental-build branch March 29, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants