Handle Template for webpack4 #759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyakov713
previously approved these changes
May 20, 2021
PsychoSanchez
previously approved these changes
May 20, 2021
ArchieSA
previously approved these changes
May 21, 2021
alexander-akait
previously approved these changes
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 6 6
Lines 805 805
Branches 247 248 +1
=======================================
Hits 719 719
Misses 83 83
Partials 3 3
Continue to review full report at Codecov.
|
|
Can you accept CLA? |
|
CLA? What does it mean? |
48524bf
|
You can found this in our github actions |
|
done |
|
@SinimaWath Can you use the same email in commit(s)? |
| @@ -619,7 +619,7 @@ class MiniCssExtractPlugin { | |||
| } | |||
| }); | |||
|
|
|||
| const { Template } = webpack; | |||
| const Template = webpack.Template || webpack.webpack.Template; | |||
There was a problem hiding this comment.
webpack.webpack doesn't exist in webpack v4 and v5, also we use:
const webpack = compiler.webpack
? compiler.webpack
: // eslint-disable-next-line global-require
require('webpack');
and for v4 and v5 we have only webpack.Template
|
Anyway thanks for PR |
|
Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Template in webpack 4 has different place.
That fix bug in nextjs. vercel/next.js#25276
Breaking Changes
Additional Info