Skip to content

chore: replace deprecated String.prototype.substr() #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2022
Merged

chore: replace deprecated String.prototype.substr() #921

merged 1 commit into from
Mar 18, 2022

Conversation

CommanderRoot
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #921 (9383ebb) into master (3fd5e5e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files           5        5           
  Lines         828      828           
  Branches      221      221           
=======================================
  Hits          748      748           
  Misses         70       70           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd5e5e...9383ebb. Read the comment docs.

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@snitin315 snitin315 merged commit 4d8e043 into webpack-contrib:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants