Skip to content

Who care npm version? #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TrySound opened this issue Dec 19, 2016 · 6 comments
Closed

Who care npm version? #153

TrySound opened this issue Dec 19, 2016 · 6 comments

Comments

@TrySound
Copy link

 "engines": {
    "node": ">=0.12",
    "npm": ">=3"
  },
@ai
Copy link
Contributor

ai commented Dec 19, 2016

Good question. Could you find an author of this change by git blame and ask him why he add it. If he will not give a good reason, let’s remove this line.

@TrySound
Copy link
Author

Hm.. I see #140 But warnings are not affects build process. So this change doesn't make sense.

@ai
Copy link
Contributor

ai commented Dec 19, 2016

Sure. But let's wait few days for origin author reasons. Maybe we missed something.

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Dec 19, 2016

@TrySound setting npm version was my fault, it's unnecessary crap, the PR author wanted to get rid of warnings triggert, because of npm version set in postcss-load-config package.json. Next postcssrc minor will fix that and I remove it in postcss-loader when bumping postcssrc version

@ai
Copy link
Contributor

ai commented Dec 19, 2016

@TrySound send PR with removing it.

@michael-ciniawsky
Copy link
Member

@TrySound fixed in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants