-
-
Notifications
You must be signed in to change notification settings - Fork 211
Update minimum NodeJS and NPM versions required #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ntwb why we should add |
@ai, Here's the details of Travis CI job I noticed this in: https://travis-ci.org/stylelint/stylelint-demo/jobs/175820550#L172 |
@ntwb so, do we need a |
Yes, which is what this PR fixes 😄 |
@ntwb and why we need it if it is already in |
If a repo you depend upon requires NodeJS v7.x, then this repo should also state that the minimum requirement is NodeJS v7.x In this case though Edit: You cannot use |
I mean when benefits user will get? npm warning will be the same? |
They will no longer get the NPM warning |
Thanks :) |
This module requires
postcss-load-config
which in turn requirespostcss-load-plugins
andpostcss-load-options
, all three of these repos have a NodeJS & NPM minimum requirement:• "engines": { "node": ">=0.12", "npm": ">=3" },`
https://github.com/michael-ciniawsky/postcss-load-config/blob/master/package.json#L5
https://github.com/michael-ciniawsky/postcss-load-plugins/blob/master/package.json#L5
https://github.com/michael-ciniawsky/postcss-load-options/blob/master/package.json#L5
To prevent warnings when using this module this repo should also follow the same min req.