Skip to content

Gracefully handle lack of compilation object #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2016
Merged

Gracefully handle lack of compilation object #101

merged 1 commit into from
Sep 22, 2016

Conversation

ertrzyiks
Copy link
Contributor

@ertrzyiks ertrzyiks commented Sep 21, 2016 •
edited
Loading

That way loader will not be fully functional when used with happypack, but at least without a crash.

Before:

ERROR in ./main.css
Module build failed: Error: Cannot read property 'applyPluginsWaterfall' of undefined
TypeError: Cannot read property 'applyPluginsWaterfall' of undefined

After

WARNING in ./main.css
this._compilation is not available thus `postcss-loader-before-processing` is not supported

@ertrzyiks
Gracefully handle lack of compilation object
b236155 
That way loader will not be fully functional when used with happypack, but at least without a crash.
@ertrzyiks ertrzyiks force-pushed the handle-lack-of-compilation-object branch from 120e2e5 to b236155 Compare September 21, 2016 08:07
@ai ai merged commit ebbef87 into webpack-contrib:master Sep 22, 2016
@ai
Copy link
Contributor

ai commented Sep 22, 2016

Sorry, I will release it with config (maybe on next week)

@ertrzyiks ertrzyiks deleted the handle-lack-of-compilation-object branch September 22, 2016 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ertrzyiks @ai