Don't force internal requires of options #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good change. I will accept it and release on this weekend (sorry, I am in the travel right now). |
if options need to be required from a specific destination, or are passed in by a different source, this is necessary `
|
Released in 1.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! So I ran into a situation where I need to require the parser myself and pass it in, rather than having it required internally, so I added this option. I couldn't quickly get my head around how the test suite works, but if you give me a push in the right direction I'd be happy to add a test for this. Meanwhile, it is a progressive upgrade, so it won't break any existing functionality.