Skip to content

test: refactor using .config.js (JS) for test configs #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2017

Conversation

alexander-akait
Copy link
Member

No description provided.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks then go 😛

@@ -0,0 +1,9 @@
module.exports = {
file: 'sourceMap-true',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sourceMap-true => sourceMap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky i think we late add sourceMap - false

@@ -0,0 +1,4 @@
test('Plugins - function', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function => {Function}

@@ -0,0 +1,8 @@
module.exports = {
file: 'plugins-function',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugins-function => plugins.fn || pluginsFn

@@ -1,4 +1,4 @@
test('Source Maps', () => {
test('Source Maps - true', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,9 @@
module.exports = {
file: 'sourceMap-inline',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sourceMap-inline => map ( Referring to PostCSS { map: 'inline'})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky Will not it be a bit confused?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... 🙃 😛 I just don't like the dash style :D

@@ -0,0 +1,4 @@
test('Source Maps - inline', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline => Inline

@michael-ciniawsky michael-ciniawsky changed the title refactor: using js for configuration test. test: refactor using .config.js (JS) for test configs May 10, 2017
@alexander-akait
Copy link
Member Author

/cc @michael-ciniawsky some fixed done, but i think using sourceMap-inline.js and sourceMap-true.js name is more clear

@michael-ciniawsky
Copy link
Member

😕 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants