-
-
Notifications
You must be signed in to change notification settings - Fork 211
test: refactor using .config.js
(JS) for test configs
#230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks then go 😛
@@ -0,0 +1,9 @@ | |||
module.exports = { | |||
file: 'sourceMap-true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sourceMap-true
=> sourceMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-ciniawsky i think we late add sourceMap - false
test/configs/plugins-function.js
Outdated
@@ -0,0 +1,4 @@ | |||
test('Plugins - function', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function
=> {Function}
@@ -0,0 +1,8 @@ | |||
module.exports = { | |||
file: 'plugins-function', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins-function
=> plugins.fn || pluginsFn
@@ -1,4 +1,4 @@ | |||
test('Source Maps', () => { | |||
test('Source Maps - true', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,9 @@ | |||
module.exports = { | |||
file: 'sourceMap-inline', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sourceMap-inline
=> map
( Referring to PostCSS { map: 'inline'}
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-ciniawsky Will not it be a bit confused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... 🙃 😛 I just don't like the dash
style :D
test/configs/sourceMap-inline.js
Outdated
@@ -0,0 +1,4 @@ | |||
test('Source Maps - inline', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline
=> Inline
js
for configuration test..config.js
(JS) for test configs
/cc @michael-ciniawsky some fixed done, but i think using |
😕 😛 |
No description provided.