test: sourcemaps with an actual plugin #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Changed my mind, better not to change these tests unless there is an actual issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
PostCSS has two modes:
LazyResultNoWorkResultNoWorkResultis an optimized path that is taken if no plugins, parsers, ... are provided.The assumption here is that the user has a bad config and doesn't actually want to use PostCSS.
LazyResultis PostCSS actually doing things.The sourcemaps generated for both modes are radically different.
This changes adds a noop plugin to trigger the
LazyResultmode.Breaking Changes
N/A
Additional Info
I don't know if this might surface subtle bugs here.
Main purpose is to have better test coverage.
I am trying to pinpoint the cause of this issue : postcss/postcss#1914