Skip to content

fix: ignore invalid URLs (url()) #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-ciniawsky merged 3 commits into from
Jan 17, 2018
Merged

fix: ignore invalid URLs (url()) #663

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8be49c3
Allow modules that resolve to falsy values in tests
kgram Jan 16, 2018
5ed83f9
Add tests for empty-object module and null module
kgram Jan 16, 2018
127468d
Do not attempt escape of non-string dependencies
kgram Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow modules that resolve to falsy values in tests
  • Loading branch information
@kgram
kgram committed Jan 16, 2018
commit 8be49c3ed10f8c728212df60b908bfab341c7683
2 changes: 1 addition & 1 deletion test/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function getEvaluated(output, modules) {
return require("../lib/url/escape");
if(module.indexOf("-!/path/css-loader!") === 0)
module = module.substr(19);
if(modules && modules[module])
if(modules && module in modules)
Copy link
Member

@alexander-akait alexander-akait Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in?

Copy link
Contributor Author

@kgram kgram Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilebottnawi: To allow for falsy modules such as { './module': null } to still be resolved.

Copy link
Member

@alexander-akait alexander-akait Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgram thanks for clafiry 👍

return modules[module];
return "{" + module + "}";
});
Expand Down